Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): add states for Turkey (tr) #2231

Merged
merged 2 commits into from
Jul 14, 2023
Merged

feat(locale): add states for Turkey (tr) #2231

merged 2 commits into from
Jul 14, 2023

Conversation

import-brain
Copy link
Member

Partially addresses #1977.

Uses data from Wikipedia

@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Jul 1, 2023
@import-brain import-brain requested a review from a team July 1, 2023 08:05
@import-brain import-brain requested a review from a team as a code owner July 1, 2023 08:05
@import-brain import-brain self-assigned this Jul 1, 2023
@codecov
Copy link

codecov bot commented Jul 1, 2023 •
edited
Loading

Codecov Report

Merging #2231 (47f5410) into next (12a511c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 47f5410 differs from pull request most recent head ebe78b5. Consider uploading reports for the commit ebe78b5 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2231      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files        2642     2640       -2     
  Lines      245795   245794       -1     
  Branches     1157     1153       -4     
==========================================
- Hits       244824   244815       -9     
- Misses        944      952       +8     
  Partials       27       27
Impacted Files Coverage Δ
src/locales/tr/location/index.ts 100.00% <100.00%> (ø)
src/locales/tr/location/state.ts 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

@import-brain import-brain mentioned this pull request Jul 3, 2023
Open
@ST-DDT ST-DDT enabled auto-merge (squash) July 14, 2023 19:56
@ST-DDT ST-DDT merged commit 2afa23f into next Jul 14, 2023
18 checks passed
@ST-DDT ST-DDT deleted the chore/tr_states branch September 11, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@import-brain import-brain

Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@import-brain @ST-DDT @xDivisionByZerox