fix(helpers): prevent uniqueArray from hanging

[matthewmayer]

fix #2207

Adds a max retry logic to uniqueArray.

I chose to use 1000*length rather than a fixed number of retries, as for example if you are
asking for a length of 2000, then 1000 retries would be insufficient.

This seems sufficient for most sensible use cases.

Obviously uniqueArray has no way to "know" how many unique values the function can return, you could define a function which returns "heads", "tails", but occasionally returns "edge" every 1000000 runs, or if the system date is a Thursday, etc etc.

[xDivisionByZerox]

The implementation looks good. The failing pipeling seems to be unrelated to your changes. So I already approve 👍

[matthewmayer]

The implementation looks good. The failing pipeling seems to be unrelated to your changes. So I already approve 👍

Yea that codecov job is quite flaky and seems to fail every so often at random.

[ST-DDT]

Instead of reinventing the unique logic, shouldn't we reuse the unique method/logic?

[codecov]

Codecov Report

Merging #2239 (8db08c5) into next (052a00c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2239   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files        2639     2639           
  Lines      244720   244728    +8     
  Branches     1082     1081    -1     
=======================================
+ Hits       243735   243744    +9     
+ Misses        958      957    -1     
  Partials       27       27           

Files Changed	Coverage Δ
src/modules/helpers/index.ts	99.09% <100.00%> (+<0.01%)	⬆️

... and 2 files with indirect coverage changes

[matthewmayer]

Instead of reinventing the unique logic, shouldn't we reuse the unique method/logic?

I thought that was deprecated?

[ST-DDT]

Let's discuss this in the next team meeting.

[ST-DDT]

Team Decision

We consider this a bandaid fix that solves the issue.
In the future we will reevaluate the entire unique feature again and then also use it consistently in all our unique methods.