fix(commerce): return fractional prices #2458

import-brain · 2023-10-09T22:47:45Z

closes #350

codecov · 2023-10-09T22:53:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (8e880c1) to head (ae6343d).

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2458   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files        2846     2846           
  Lines      248656   248715   +59     
  Branches      642      654   +12     
=======================================
+ Hits       247581   247643   +62     
+ Misses       1075     1072    -3

Files	Coverage Δ
src/modules/commerce/index.ts	`98.98% <100.00%> (+0.13%)`	⬆️

... and 2 files with indirect coverage changes

matthewmayer

This doesn't seem very realistic, e-commerce sites don't typically have random numbers of cents on a price for items above $100. It's more common to round to a nice number like .00 or .95 or .99

ST-DDT · 2023-10-10T15:18:54Z

There are some prices that are like 1.20€ like a serving of ice.

ST-DDT · 2023-10-10T18:08:08Z

Amazon Prime Video today:

But I must admit a price like 10.09€ is rare.

matthewmayer · 2023-10-11T00:19:52Z

I think a more realistic algorithm for prices might be:

Generate the raw price
Round to 2 or 3 significant digits (e.g. 1.23 or 12.30 or 123.00 or 1230.00)
Optionally deduct 0.01 or 0.05

import-brain · 2023-10-11T05:56:50Z

There are some prices that are like 1.20€ like a serving of ice.

Also, when you convert a price from one currency to another, you often get something like "$120.14".

ST-DDT · 2023-10-17T16:00:33Z

Team Decision

We will alter the distribution to favor the special numbers by using faker.helpers.weightedArrayElement for the last decimal digit.

9: weight: 5
5: weight: 3
0: weight: 1
random(0-9): weight: 1

If the dec is zero we will skip this behavior.

import-brain · 2024-02-10T13:02:32Z

@import-brain Could you please update this PR or should we take it over?

@ST-DDT Could you please take this over?

ST-DDT · 2024-02-11T10:30:53Z

Sure no problem. This might take a bit though.

ST-DDT · 2024-02-29T11:12:58Z

Here a few prices that are returned by the price method:

Summary

Last Digit	Occurrences
0	13
1	0
2	1
3	1
4	2
5	30
6	1
7	1
8	2
9	49

Values

Price	Last Digit
278.39	9
224.59	9
171.99	9
968.26	6
832.10	0
911.79	9
345.35	5
842.69	9
636.79	9
325.29	9
666.80	0
891.55	5
897.49	9
377.09	9
731.65	5
821.55	5
650.40	0
595.09	9
268.18	8
461.00	0
188.25	5
915.30	0
483.49	9
1.19	9
203.95	5
611.29	9
546.49	9
297.95	5
759.49	9
344.69	9
388.89	9
898.15	5
319.95	5
99.25	5
399.69	9
269.45	5
562.29	9
336.45	5
628.39	9
24.99	9
89.65	5
380.05	5
183.99	9
647.03	3
896.95	5
37.45	5
581.39	9
70.79	9
281.10	0
878.29	9
838.05	5
940.95	5
692.09	9
938.20	0
936.89	9
339.45	5
663.55	5
664.19	9
663.59	9
234.55	5
609.69	9
817.09	9
448.55	5
755.69	9
514.15	5
406.72	2
368.75	5
375.50	0
377.60	0
633.69	9
813.09	9
281.39	9
834.69	9
639.95	5
729.39	9
91.50	0
497.29	9
281.49	9
771.09	9
803.69	9
159.85	5
386.79	9
738.77	7
442.85	5
210.74	4
569.78	8
171.84	4
206.19	9
732.79	9
305.89	9
181.55	5
311.39	9
694.30	0
413.45	5
317.80	0
483.20	0
599.19	9
765.69	9
34.89	9
507.65	5

ST-DDT · 2024-02-29T11:13:18Z

Ready for review

matthewmayer · 2024-02-29T14:38:06Z

While it's not strictly a breaking change I think it's worth a mention in the migration guide given that it changes the behavior of the method.

ST-DDT · 2024-02-29T18:24:15Z

While it's not strictly a breaking change I think it's worth a mention in the migration guide given that it changes the behavior of the method.

Added

fix: return fractional prices from commerce.price

d4b6bc7

import-brain added c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: commerce Something is referring to the commerce module labels Oct 9, 2023

import-brain added this to the vAnytime milestone Oct 9, 2023

import-brain requested a review from a team October 9, 2023 22:47

import-brain self-assigned this Oct 9, 2023

import-brain requested a review from a team as a code owner October 9, 2023 22:47

docs: edit jsdoc to reflect decimal change

6b74642

ST-DDT previously approved these changes Oct 9, 2023

View reviewed changes

ST-DDT requested a review from a team October 9, 2023 23:16

xDivisionByZerox previously approved these changes Oct 10, 2023

View reviewed changes

matthewmayer requested changes Oct 10, 2023

View reviewed changes

feat: weighted last digits

0f0286b

import-brain dismissed stale reviews from xDivisionByZerox and ST-DDT via 0f0286b October 18, 2023 18:55

import-brain added 2 commits October 18, 2023 22:05

Merge branch 'next' into fix/fract_currency_prices

2bc5188

chore: run preflight

46b64da

ST-DDT approved these changes Oct 19, 2023

View reviewed changes

ST-DDT requested review from matthewmayer, xDivisionByZerox and a team October 19, 2023 07:43

Merge branch 'next' into fix/fract_currency_prices

1dfe91d

ST-DDT added 3 commits February 29, 2024 11:34

Merge branch 'next' into fix/fract_currency_prices

8357168

chore: fix test

baf71df

chore: improve readability

2802e3c

ST-DDT previously approved these changes Feb 29, 2024

View reviewed changes

ST-DDT requested review from matthewmayer and a team February 29, 2024 11:14

ST-DDT dismissed their stale review via 2802e3c February 29, 2024 11:16

ST-DDT previously approved these changes Feb 29, 2024

View reviewed changes

ST-DDT requested a review from a team February 29, 2024 11:18

docs: add upgrading guide

5689c92

ST-DDT dismissed their stale review via 5689c92 February 29, 2024 18:22

import-brain requested a review from a team February 29, 2024 18:22

ST-DDT approved these changes Feb 29, 2024

View reviewed changes

ST-DDT requested a review from a team February 29, 2024 18:24

matthewmayer approved these changes Mar 1, 2024

View reviewed changes

ST-DDT added 2 commits March 1, 2024 01:58

Merge branch 'next' into fix/fract_currency_prices

7cc2e59

Merge branch 'next' into fix/fract_currency_prices

ae6343d

ST-DDT self-assigned this Mar 1, 2024

Shinigami92 approved these changes Mar 1, 2024

View reviewed changes

ST-DDT changed the title ~~fix: return fractional prices from commerce.price()~~ fix(commerce): return fractional prices Mar 1, 2024

ST-DDT merged commit 9348138 into next Mar 1, 2024
18 checks passed

ST-DDT deleted the fix/fract_currency_prices branch March 1, 2024 22:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(commerce): return fractional prices #2458

fix(commerce): return fractional prices #2458

import-brain commented Oct 9, 2023

codecov bot commented Oct 9, 2023 •

edited

matthewmayer left a comment

ST-DDT commented Oct 10, 2023

ST-DDT commented Oct 10, 2023

matthewmayer commented Oct 11, 2023

import-brain commented Oct 11, 2023 •

edited

ST-DDT commented Oct 17, 2023

import-brain commented Feb 10, 2024

ST-DDT commented Feb 11, 2024

ST-DDT commented Feb 29, 2024

ST-DDT commented Feb 29, 2024

matthewmayer commented Feb 29, 2024 •

edited

ST-DDT commented Feb 29, 2024

fix(commerce): return fractional prices #2458

fix(commerce): return fractional prices #2458

Conversation

import-brain commented Oct 9, 2023

codecov bot commented Oct 9, 2023 • edited

Codecov Report

matthewmayer left a comment

Choose a reason for hiding this comment

ST-DDT commented Oct 10, 2023

ST-DDT commented Oct 10, 2023

matthewmayer commented Oct 11, 2023

import-brain commented Oct 11, 2023 • edited

ST-DDT commented Oct 17, 2023

import-brain commented Feb 10, 2024

ST-DDT commented Feb 11, 2024

ST-DDT commented Feb 29, 2024

ST-DDT commented Feb 29, 2024

matthewmayer commented Feb 29, 2024 • edited

ST-DDT commented Feb 29, 2024

codecov bot commented Oct 9, 2023 •

edited

import-brain commented Oct 11, 2023 •

edited

matthewmayer commented Feb 29, 2024 •

edited