feat(person): use fake patterns for jobTitle #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2528 +/- ##
==========================================
+ Coverage 99.56% 99.57% +0.01%
==========================================
Files 2779 2781 +2
Lines 249303 249317 +14
Branches 1075 1082 +7
==========================================
+ Hits 248221 248266 +45
+ Misses 1054 1023 -31
Partials 28 28
|
matthewmayer
added
m: person
matthewmayer
changed the title
ST-DDT
approved these changes
Nov 5, 2023
xDivisionByZerox
approved these changes
Nov 6, 2023
ST-DDT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently faker.person.jobTitle is hardcoded to use the order:
{{person.jobDescriptor}} {{person.jobArea}} {{person.jobType}}e.g. Senior Marketing Executive
However in some languages, like Spanish or French, typically the adjectives would follow the noun ie
type area descriptorAnd in some languages like Thai or Chinese although they follow an English word order, there should be no spaces between the parts.
This PR permits better localization by allowing a fake pattern for the job title. I just added English and Spanish for now as demos, other languages could be added as needed. If no job_title_pattern is found it would fall back to en, keeping current behavior.