Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend list of domain suffix for PL locale #266

Merged
merged 5 commits into from Apr 5, 2022

Conversation

pkuczynski
Copy link
Member

Based on list from Polish TLD registrar NASK: https://www.dns.pl/lista_domen_funkcjonalnych

I kept only those which has specific Polish names and skipped things like tourism.pl which is not a polish word.

@pkuczynski pkuczynski requested a review from a team as a code owner January 23, 2022 16:33
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 23, 2022
@Shinigami92 Shinigami92 added c: feature Request for new feature c: locale Permutes locale definitions and removed c: feature Request for new feature labels Mar 15, 2022
@Shinigami92 Shinigami92 requested review from a team April 5, 2022 15:48
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #266 (a7f8400) into main (c6d0cc7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a7f8400 differs from pull request most recent head d66ed1f. Consider uploading reports for the commit d66ed1f to get more accurate results

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1921     1921              
  Lines      176644   176559      -85     
  Branches      905      912       +7     
==========================================
- Hits       175491   175402      -89     
- Misses       1097     1101       +4     
  Partials       56       56              
Impacted Files Coverage Δ
src/locales/pl/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/address.ts 99.09% <0.00%> (-0.72%) ⬇️
src/lorem.ts 100.00% <0.00%> (ø)
src/definitions/address.ts 100.00% <0.00%> (ø)
src/locales/ar/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/az/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/cz/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/de/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/en/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/fr/address/street_address.ts 100.00% <0.00%> (ø)
... and 25 more

@ST-DDT ST-DDT requested a review from a team April 5, 2022 17:01
@ST-DDT ST-DDT enabled auto-merge (squash) April 5, 2022 22:30
@ST-DDT ST-DDT merged commit 5beac4b into faker-js:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants