Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(internet)!: remove v8 deprecated internet methods #2699

Merged
merged 1 commit into from
Mar 1, 2024
Merged

refactor(internet)!: remove v8 deprecated internet methods #2699

merged 1 commit into from
Mar 1, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: internet Something is referring to the internet module labels Feb 29, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Feb 29, 2024
@Shinigami92 Shinigami92 self-assigned this Feb 29, 2024
@Shinigami92 Shinigami92 force-pushed the remove-deprecated-internet-methods branch from e3fba61 to 8016d30 Compare February 29, 2024 18:25
@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (e99fba9) to head (baaab99).

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2699      +/-   ##
==========================================
- Coverage   99.58%   99.57%   -0.01%     
==========================================
  Files        2846     2846              
  Lines      249416   248656     -760     
  Branches     1045      645     -400     
==========================================
- Hits       248369   247595     -774     
- Misses       1018     1061      +43     
+ Partials       29        0      -29
Files Coverage Δ
src/modules/internet/index.ts 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

@Shinigami92 Shinigami92 force-pushed the remove-deprecated-internet-methods branch from 8016d30 to baaab99 Compare February 29, 2024 18:29
@Shinigami92 Shinigami92 marked this pull request as ready for review February 29, 2024 18:29
@Shinigami92 Shinigami92 requested a review from a team February 29, 2024 18:29
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 29, 2024 18:29
@Shinigami92 Shinigami92 added the breaking change Cannot be merged when next version is not a major release label Feb 29, 2024
@ST-DDT ST-DDT requested review from a team February 29, 2024 18:44
@ST-DDT ST-DDT merged commit 3024d9e into next Mar 1, 2024
17 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-internet-methods branch March 1, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: internet Something is referring to the internet module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox