Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(date)!: remove v8 deprecated date methods #2704

Merged
merged 4 commits into from
Mar 5, 2024
Merged

refactor(date)!: remove v8 deprecated date methods #2704

merged 4 commits into from
Mar 5, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Mar 3, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Mar 3, 2024
@Shinigami92 Shinigami92 self-assigned this Mar 3, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 3, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (2bf8974) to head (0e5fc48).

❗ Current head 0e5fc48 differs from pull request most recent head 72efe2d. Consider uploading reports for the commit 72efe2d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2704      +/-   ##
==========================================
- Coverage   99.57%   99.56%   -0.02%     
==========================================
  Files        2859     2846      -13     
  Lines      249642   247998    -1644     
  Branches     1009      627     -382     
==========================================
- Hits       248582   246908    -1674     
- Misses       1060     1090      +30
Files Coverage Δ
src/modules/date/index.ts 99.82% <100.00%> (-0.10%) ⬇️

... and 17 files with indirect coverage changes

@Shinigami92 Shinigami92 force-pushed the remove-deprecated-date-methods branch from 0748d6c to cf53240 Compare March 3, 2024 10:25
@Shinigami92 Shinigami92 marked this pull request as ready for review March 3, 2024 10:25
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 3, 2024 10:25
@Shinigami92 Shinigami92 changed the title refactor(internet)!: remove v8 deprecated date methods refactor(date)!: remove v8 deprecated date methods Mar 3, 2024
@Shinigami92 Shinigami92 added the s: needs decision Needs team/maintainer decision label Mar 3, 2024
@ST-DDT ST-DDT mentioned this pull request Mar 4, 2024
Closed
@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Mar 4, 2024
@ST-DDT ST-DDT requested review from matthewmayer and a team March 4, 2024 12:51
@ST-DDT ST-DDT enabled auto-merge (squash) March 5, 2024 09:53
@ST-DDT ST-DDT merged commit e868060 into next Mar 5, 2024
14 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-date-methods branch March 5, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shinigami92 @matthewmayer @ST-DDT