refactor(date)!: stricter error handling of between #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2719 +/- ##
=========================================
Coverage 99.93% 99.94%
=========================================
Files 2960 2958 -2
Lines 211338 213714 +2376
Branches 594 602 +8
=========================================
+ Hits 211203 213592 +2389
+ Misses 135 118 -17
- Partials 0 4 +4
|
ST-DDT
reviewed
Mar 5, 2024
ST-DDT
added
p: 1-normal
matthewmayer
changed the title
matthewmayer
added
the
breaking change
matthewmayer
changed the title
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
ST-DDT
reviewed
Mar 5, 2024
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
ST-DDT
previously approved these changes
Mar 11, 2024
ST-DDT
reviewed
Mar 12, 2024
ST-DDT
previously approved these changes
Mar 12, 2024
|
I'm in contact with the codecov team regarding the increased error rate. |
|
I guess this should revert back to using the new improved "toDate" now that has been merged? |
|
Yes, please. |
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewmayer
removed
the
s: on hold
ST-DDT
reviewed
Mar 25, 2024
ST-DDT
reviewed
Mar 25, 2024
ST-DDT
previously approved these changes
Mar 25, 2024
Shinigami92
reviewed
Mar 25, 2024
ST-DDT
approved these changes
Mar 27, 2024
Shinigami92
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2711
Note i didn't change
toDatefunction, as the new version ofbetweendoesn't need it any more. That could be done in a seperate PR if required.Some errors are only possible to trigger in JS (e.g. omitting params) but invalid string dates can be passed in TS too.