Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(helpers)!: remove v8 deprecated helpers methods #2729

Merged
merged 6 commits into from
Mar 13, 2024
Merged

refactor(helpers)!: remove v8 deprecated helpers methods #2729

merged 6 commits into from
Mar 13, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: helpers Something is referring to the helpers module labels Mar 10, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Mar 10, 2024
@Shinigami92 Shinigami92 self-assigned this Mar 10, 2024
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 10, 2024 09:27
@Shinigami92 Shinigami92 marked this pull request as draft March 10, 2024 09:27
@Shinigami92 Shinigami92 marked this pull request as ready for review March 10, 2024 09:29
@codecov Codecov
Copy link

codecov bot commented Mar 10, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (1b1163e) to head (690630f).

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2729      +/-   ##
==========================================
- Coverage   99.57%   99.56%   -0.01%     
==========================================
  Files        3034     3034              
  Lines      250499   250434      -65     
  Branches      627      979     +352     
==========================================
- Hits       249442   249356      -86     
- Misses       1057     1078      +21
Files Coverage Δ
src/modules/helpers/index.ts 98.38% <100.00%> (-0.37%) ⬇️

... and 1 file with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Mar 10, 2024
View reviewed changes
@ST-DDT ST-DDT requested review from a team March 10, 2024 10:52
matthewmayer
matthewmayer requested changes Mar 10, 2024
View reviewed changes
docs/guide/upgrading_v9/2729.md Show resolved Hide resolved
docs/guide/upgrading_v9/2729.md Show resolved Hide resolved
@ST-DDT ST-DDT enabled auto-merge (squash) March 13, 2024 12:24
@ST-DDT ST-DDT merged commit 1169a05 into next Mar 13, 2024
16 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-helpers-methods branch March 13, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shinigami92 @matthewmayer @ST-DDT