Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(number)!: remove v8 deprecated number parameter #2738

Merged
merged 3 commits into from
Mar 12, 2024
Merged

refactor(number)!: remove v8 deprecated number parameter #2738

merged 3 commits into from
Mar 12, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: number Something is referring to the number module labels Mar 12, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Mar 12, 2024
@Shinigami92 Shinigami92 self-assigned this Mar 12, 2024
@Shinigami92 Shinigami92 marked this pull request as ready for review March 12, 2024 09:09
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 12, 2024 09:09
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (next@19bcf88). Click here to learn what that means.

❗ Current head a3bd26f differs from pull request most recent head 841440a. Consider uploading reports for the commit 841440a to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2738   +/-   ##
=======================================
  Coverage        ?   99.57%           
=======================================
  Files           ?     2859           
  Lines           ?   248579           
  Branches        ?      984           
=======================================
  Hits            ?   247519           
  Misses          ?     1060           
  Partials        ?        0
Files Coverage Δ
src/modules/number/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT requested review from a team March 12, 2024 09:56
@ST-DDT ST-DDT enabled auto-merge (squash) March 12, 2024 14:48
@ST-DDT ST-DDT merged commit a672d27 into next Mar 12, 2024
14 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-number-parameter branch March 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: number Something is referring to the number module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox