Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale)!: remove unused global locale faker instance #2789

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 7, 2024

Removes the unused global faker instance that is only a copy of the base one.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Apr 7, 2024
@ST-DDT ST-DDT added this to the v9.0 milestone Apr 7, 2024
@ST-DDT ST-DDT self-assigned this Apr 7, 2024
Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit a99cf13
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/661415f2276ef200085be681
😎 Deploy Preview https://deploy-preview-2789.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (cbbe218) to head (c9536df).

❗ Current head c9536df differs from pull request most recent head a99cf13. Consider uploading reports for the commit a99cf13 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2789      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files        2972     2971       -1     
  Lines      212564   212553      -11     
  Branches      952      594     -358     
==========================================
- Hits       212470   212453      -17     
- Misses         93      100       +7     
+ Partials        1        0       -1     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT marked this pull request as ready for review April 7, 2024 16:14
@ST-DDT ST-DDT requested a review from a team as a code owner April 7, 2024 16:14
@ST-DDT ST-DDT requested a review from a team April 7, 2024 16:14
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused here 🤔
Why is it okay here to remove it directly without any runtime deprecation warning?
Also, is this just a missed left-over and we forgot to remove it once we build the PR?

@xDivisionByZerox
Copy link
Member

Why is it okay here to remove it directly without any runtime deprecation warning?

Because it was never meant to be in a release. This is an artifact from the introduction of the base locale, AFAICT.

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the responsibility on the other team-members, I approve

@ST-DDT ST-DDT enabled auto-merge (squash) April 8, 2024 16:06
@ST-DDT ST-DDT merged commit b505a70 into next Apr 8, 2024
18 checks passed
@ST-DDT ST-DDT deleted the refactor/locale/global branch April 17, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants