npm install fails for package consumers due to "only-allow pnpm"

[jbkly]

Describe the bug

First line of the readme Installation section suggests you can use npm, yarn, or pnpm to install faker:

npm install @faker-js/faker --save-dev

❯ npm install @faker-js/faker --save-dev
npm ERR! code 1
npm ERR! path ~/dev/myproject/node_modules/@faker-js/faker
npm ERR! command failed
npm ERR! command sh -c npx only-allow pnpm
npm ERR! ╔═════════════════════════════════════════════════════════════╗
npm ERR! ║                                                             ║
npm ERR! ║   Use "pnpm install" for installation in this project.      ║
npm ERR! ║                                                             ║
npm ERR! ║   If you don't have pnpm, install it via "npm i -g pnpm".   ║
npm ERR! ║   For more details, go to https://pnpm.js.org/              ║
npm ERR! ║                                                             ║
npm ERR! ╚═════════════════════════════════════════════════════════════╝

npm ERR! A complete log of this run can be found in:
npm ERR!     ~/.npm/_logs/2022-01-24T23_47_37_989Z-debug.log

This commit (a273f67) added "preinstall": "npx only-allow pnpm" to package.json.

Reproduction

npm install @faker-js/faker --save-dev

Additional Info

No response

[ST-DDT]

This looks like a bug to me. @Shinigami92

[edilsonalves]

The same happens to me.

⚡️ npm install @faker-js/faker --save-dev
npm ERR! code 1
npm ERR! path /Users/edilson/Desktop/ze-projects/ze-communication-service/node_modules/@faker-js/faker
npm ERR! command failed
npm ERR! command sh -c npx only-allow pnpm
npm ERR! ╔═════════════════════════════════════════════════════════════╗
npm ERR! ║                                                             ║
npm ERR! ║   Use "pnpm install" for installation in this project.      ║
npm ERR! ║                                                             ║
npm ERR! ║   If you don't have pnpm, install it via "npm i -g pnpm".   ║
npm ERR! ║   For more details, go to https://pnpm.js.org/              ║
npm ERR! ║                                                             ║
npm ERR! ╚═════════════════════════════════════════════════════════════╝

npm ERR! A complete log of this run can be found in:
npm ERR!     ~/.npm/_logs/2022-01-25T00_21_50_304Z-debug.log

[Lamia-Mihoubi]

Same:

[Shinigami92]

What 😱
How is this not a bug for half a million people using Vite but for us 👀

There must be something I missed to correctly configure 🤔

[Shinigami92]

Another team member at Vite explained me:

vite uses it in the monorepo root, which doesn't get published

I'm so sorry 🤦 I really didn't thought that preinstall will be just executed. Is this not a huge CVE? 👀🤔 is it possible to just rm -Rf * in preinstall?

[nimatrazmjo]

same

:

[ST-DDT]

@damienwebdev Any ETA on a fixed release?

[feedm3]

Quick fix for now: Pin the version in your package.json to 6.0.0-alpha.3:

"@faker-js/faker": "6.0.0-alpha.3"

[Shinigami92]

https://www.npmjs.com/package/@faker-js/faker/v/6.0.0-alpha.5 it's released 🥳

Sorry for that issue, but I'm happy that we have the alpha-phase