Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): provide strong typing for locales #363

Merged
merged 42 commits into from
Feb 1, 2022
Merged

feat(types): provide strong typing for locales #363

merged 42 commits into from
Feb 1, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 30, 2022 •
edited
Loading

In this first stage I only compare what the methods that use the definitions (likely) return and compare that to the locale en.

@ST-DDT ST-DDT self-assigned this Jan 30, 2022
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation c: feature Request for new feature labels Jan 30, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 30, 2022

The changes in the locales/index.ts files are only temporary to support filtering unneeded entries.

This was referenced Jan 30, 2022
Closed
Closed
@Shinigami92 Shinigami92 self-requested a review January 31, 2022 07:56
@Shinigami92
Copy link
Member

I will review this today in VSCode when I have a time-slot

Shinigami92
Shinigami92 reviewed Jan 31, 2022
View reviewed changes
src/definitions/company.ts Outdated Show resolved Hide resolved
src/definitions/company.ts Outdated Show resolved Hide resolved
src/definitions/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/locales/en/address/index.ts Show resolved Hide resolved
ST-DDT
ST-DDT commented Jan 31, 2022
View reviewed changes
Copy link
Member Author

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed most of the simple types.

src/definitions/finance.ts Outdated Show resolved Hide resolved
src/definitions/system.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 reviewed Jan 31, 2022
View reviewed changes
src/definitions/utils.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 requested review from a team January 31, 2022 21:53
@ST-DDT ST-DDT mentioned this pull request Feb 1, 2022
Closed
@ST-DDT ST-DDT requested a review from a team February 1, 2022 09:39
@ST-DDT ST-DDT merged commit 5e6754d into main Feb 1, 2022
@ST-DDT ST-DDT deleted the locales/strong-types branch February 1, 2022 16:31
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
@ST-DDT @bmenant
feat(types): provide strong typing for locales (faker-js#363)
5fc0cbb
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@ST-DDT @demipel8
feat(types): provide strong typing for locales (faker-js#363)
7086392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation c: feature Request for new feature
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ST-DDT @Shinigami92 @prisis