Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unique method types #457

Merged
merged 5 commits into from Feb 10, 2022
Merged

fix: fix unique method types #457

merged 5 commits into from Feb 10, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 9, 2022

Fixes #456

Note: There is a slight imprecision I couldn't remove.
It is possible to omit the parameters, although the referenced method requires them.
If I fix that, it is no longer possible to omit the empty parameter array.

@ST-DDT ST-DDT added the c: bug Something isn't working label Feb 9, 2022
@ST-DDT ST-DDT requested a review from a team February 9, 2022 14:55
@ST-DDT ST-DDT self-assigned this Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #457 (4a40f2c) into main (c208777) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4a40f2c differs from pull request most recent head b2e830e. Consider uploading reports for the commit b2e830e to get more accurate results

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files        1920     1920              
  Lines      174378   174323      -55     
  Branches      896      896              
==========================================
- Hits       173219   173163      -56     
- Misses       1103     1104       +1     
  Partials       56       56              
Impacted Files Coverage Δ
src/unique.ts 100.00% <100.00%> (ø)
src/vendor/unique.ts 95.96% <100.00%> (+0.09%) ⬆️
src/helpers.ts 99.30% <0.00%> (-0.18%) ⬇️
src/address.ts 98.55% <0.00%> (-0.16%) ⬇️

@ST-DDT ST-DDT mentioned this pull request Feb 9, 2022
@Shinigami92
Copy link
Member

Did you see #333 ?

@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 9, 2022

No, i didn't see it (or forgot about it).
This variant also covers non string returning methods.
(But I'm fine, with closing this one, if the other ones get updated and supports non string methods.)

@Shinigami92 Shinigami92 requested a review from a team February 10, 2022 19:35
@Shinigami92 Shinigami92 merged commit 14df7d3 into main Feb 10, 2022
@Shinigami92 Shinigami92 deleted the fix/unique-types branch February 10, 2022 22:52
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

faker.unique TS error
3 participants