Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move el credit card information to the expected location #484

Merged
merged 5 commits into from Feb 15, 2022
Merged

fix: move el credit card information to the expected location #484

merged 5 commits into from Feb 15, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 13, 2022

Fixes: #376

@ST-DDT ST-DDT added the c: feature Request for new feature label Feb 13, 2022
@ST-DDT ST-DDT requested a review from a team February 13, 2022 22:37
@ST-DDT ST-DDT self-assigned this Feb 13, 2022
@codecov
Copy link

codecov bot commented Feb 13, 2022 •
edited

Codecov Report

Merging #484 (a961f71) into main (2f94155) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a961f71 differs from pull request most recent head 70bd23f. Consider uploading reports for the commit 70bd23f to get more accurate results

@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1919     1919           
  Lines      176291   176291           
  Branches      902      902           
=======================================
  Hits       175135   175135           
  Misses       1100     1100           
  Partials       56       56
Impacted Files Coverage Δ
...locales/el/finance/credit_card/american_express.ts 100.00% <ø> (ø)
src/locales/el/finance/credit_card/discover.ts 100.00% <ø> (ø)
src/locales/el/finance/credit_card/maestro.ts 100.00% <ø> (ø)
src/locales/el/finance/credit_card/mastercard.ts 100.00% <ø> (ø)
src/locales/el/finance/credit_card/visa.ts 100.00% <ø> (ø)
src/locales/el/index.ts 100.00% <ø> (ø)
src/locales/el/finance/credit_card/index.ts 100.00% <100.00%> (ø)
src/locales/el/finance/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT mentioned this pull request Feb 13, 2022
Closed
@Shinigami92 Shinigami92 requested a review from a team February 14, 2022 07:38
@ST-DDT ST-DDT merged commit dcbd18e into main Feb 15, 2022
@ST-DDT ST-DDT deleted the fix/locales/el/credit_card branch February 15, 2022 14:30
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@ST-DDT @demipel8
fix: move el credit card information to the expected location (faker-…
c8445e7 
…js#484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: feature Request for new feature
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.

Greek locale species the credit card at the wrong location
4 participants
@ST-DDT @prisis @Shinigami92 @import-brain