Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid aliases #488

Merged
merged 3 commits into from Feb 15, 2022
Merged

fix: remove invalid aliases #488

merged 3 commits into from Feb 15, 2022

Conversation

Shinigami92
Copy link
Member

While rewriting to TS I added accidentally some aliases.
These are not needed

@Shinigami92 Shinigami92 self-assigned this Feb 14, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 14, 2022 17:14
@ST-DDT
Copy link
Member

ST-DDT commented Feb 14, 2022

These are not needed

= Not in 5.5.3

@ST-DDT ST-DDT added the c: bug Something isn't working label Feb 14, 2022
@ST-DDT ST-DDT requested a review from a team February 14, 2022 17:18
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #488 (ab3abcd) into main (fceb128) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ab3abcd differs from pull request most recent head fdfd0ba. Consider uploading reports for the commit fdfd0ba to get more accurate results

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1919     1919              
  Lines      176173   176164       -9     
  Branches      904      903       -1     
==========================================
- Hits       175019   175009      -10     
- Misses       1098     1099       +1     
  Partials       56       56              
Impacted Files Coverage Δ
src/random.ts 99.55% <ø> (-0.01%) ⬇️
src/vendor/unique.ts 95.96% <0.00%> (-1.62%) ⬇️
src/vendor/user-agent.ts 97.75% <0.00%> (+0.28%) ⬆️

@ST-DDT ST-DDT merged commit 58fbfe3 into main Feb 15, 2022
@ST-DDT ST-DDT deleted the remove-wrong-aliases branch February 15, 2022 15:05
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants