Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: display correct signature #596

Merged
merged 5 commits into from Mar 7, 2022
Merged

docs: display correct signature #596

merged 5 commits into from Mar 7, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 4, 2022

Fixes #592

Diff

Old:
grafik

New:
grafik

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation c: feature Request for new feature labels Mar 4, 2022
@ST-DDT ST-DDT self-assigned this Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #596 (f871599) into main (5595b9f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f871599 differs from pull request most recent head da7e2a2. Consider uploading reports for the commit da7e2a2 to get more accurate results

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1920     1920              
  Lines      176424   176444      +20     
  Branches      906      904       -2     
==========================================
+ Hits       175269   175287      +18     
- Misses       1099     1101       +2     
  Partials       56       56              
Impacted Files Coverage Δ
src/random.ts 99.41% <100.00%> (+0.02%) ⬆️
src/vendor/unique.ts 95.96% <0.00%> (-1.62%) ⬇️

@ST-DDT ST-DDT marked this pull request as ready for review March 7, 2022 18:38
@ST-DDT ST-DDT requested a review from a team as a code owner March 7, 2022 18:38
@ST-DDT ST-DDT requested a review from a team March 7, 2022 19:26
@ST-DDT ST-DDT merged commit c115056 into main Mar 7, 2022
@ST-DDT ST-DDT deleted the docs/use-last-signature branch March 7, 2022 19:37
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: feature Request for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add support for multiple signatures
3 participants