Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix eslint error #597

Merged
merged 4 commits into from
Mar 7, 2022
Merged

chore: fix eslint error #597

merged 4 commits into from
Mar 7, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Mar 4, 2022 •
edited
Loading

Related to #595 (comment)

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Mar 4, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 4, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 4, 2022 13:26
@codecov
Copy link

codecov bot commented Mar 4, 2022 •
edited
Loading

Codecov Report

Merging #597 (137c4b2) into main (c99160f) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 137c4b2 differs from pull request most recent head c2e8707. Consider uploading reports for the commit c2e8707 to get more accurate results

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1920     1920              
  Lines      176444   176424      -20     
  Branches      904      904              
==========================================
- Hits       175287   175267      -20     
  Misses       1101     1101              
  Partials       56       56
Impacted Files Coverage Δ
src/random.ts 99.39% <0.00%> (-0.03%) ⬇️

@Shinigami92 Shinigami92 mentioned this pull request Mar 4, 2022
Merged
@ST-DDT ST-DDT requested a review from a team March 4, 2022 13:41
@Shinigami92 Shinigami92 merged commit 4f7447c into main Mar 7, 2022
@Shinigami92 Shinigami92 deleted the fix-eslint-error branch March 7, 2022 19:55
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
chore: fix eslint error (faker-js#597)
4831e14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis prisis approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shinigami92 @ST-DDT @prisis @import-brain