chore: fix some lint warnings #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: feature
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 99.33% 99.33% -0.01%
==========================================
Files 1920 1920
Lines 176469 176483 +14
Branches 900 905 +5
==========================================
+ Hits 175292 175303 +11
- Misses 1121 1124 +3
Partials 56 56
|
prisis
previously approved these changes
Mar 15, 2022
Shinigami92
reviewed
Mar 15, 2022
Shinigami92
reviewed
Mar 15, 2022
| if (Array.isArray(source)) { | ||
| const set = new Set(source); | ||
| const set = new Set<T>(source); | ||
| const array = Array.from(set); | ||
| return this.faker.helpers.shuffle(array).splice(0, length); |
There was a problem hiding this comment.
Just a note for a later PR, IMO we should use slice instead of splice here 🤔
Shinigami92
approved these changes
Mar 15, 2022
prisis
approved these changes
Mar 15, 2022
Closed
ST-DDT
modified the milestones:
v6 - Non-Breaking Changes,
v6.0 - Ensure Project Foundation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.