Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable algolia search #641

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Conversation

prisis
Copy link
Member

@prisis prisis commented Mar 21, 2022

I added the env's into netlify

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #641 (778aebb) into main (7f32614) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files        1923     1923           
  Lines      176853   176853           
  Branches      906      906           
=======================================
  Hits       175681   175681           
  Misses       1116     1116           
  Partials       56       56           

@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug labels Mar 21, 2022
@Shinigami92
Copy link
Member

I cannot review if it's working due to I do not have the API_KEY in my local envs

Can we somehow test this PR with a netlify preview?
Otherwise, did you test it manually?

Copy link
Contributor

@griest024 griest024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine but I did not acceptance test. Should this close #222 ?

@Shinigami92 Shinigami92 linked an issue Mar 21, 2022 that may be closed by this pull request
@prisis
Copy link
Member Author

prisis commented Mar 23, 2022

Tested it on my local en

Bildschirmaufnahme.2022-03-23.08.26.18.mp4

@Shinigami92 Shinigami92 changed the title fix(#222): enable algolia search again fix: enable algolia search Mar 23, 2022
@Shinigami92 Shinigami92 merged commit a759c87 into faker-js:main Mar 23, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Mar 23, 2022

Works like a charm!

@prisis prisis deleted the feature/algoila branch March 23, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: hook up algolia search
4 participants