Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: name module gender #644

Merged
merged 28 commits into from
Mar 24, 2022
Merged

fix: name module gender #644

merged 28 commits into from
Mar 24, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 21, 2022
@Shinigami92 Shinigami92 added this to the v6.1 - First bugfixes milestone Mar 21, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #644 (055bf09) into main (d0a473f) will increase coverage by 0.00%.
The diff coverage is 99.31%.

@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   99.33%   99.34%           
=======================================
  Files        1923     1923           
  Lines      176841   176837    -4     
  Branches      911      900   -11     
=======================================
+ Hits       175671   175678    +7     
+ Misses       1114     1103   -11     
  Partials       56       56           
Impacted Files Coverage Δ
src/index.ts 94.87% <50.00%> (-2.43%) ⬇️
src/name.ts 100.00% <100.00%> (+3.88%) ⬆️
src/vendor/user-agent.ts 98.03% <0.00%> (-0.29%) ⬇️

@Shinigami92 Shinigami92 marked this pull request as ready for review March 21, 2022 16:56
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 21, 2022 16:56
src/name.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 requested review from ST-DDT and a team March 21, 2022 18:37
ST-DDT
ST-DDT previously approved these changes Mar 21, 2022
@ST-DDT ST-DDT requested a review from a team March 21, 2022 18:44
src/name.ts Outdated Show resolved Hide resolved
src/name.ts Outdated Show resolved Hide resolved
src/name.ts Outdated Show resolved Hide resolved
src/name.ts Outdated Show resolved Hide resolved
@JessicaSachs
Copy link
Contributor

Should we go ahead and add support for the gender non-binary in this PR? You're setting up the types and infrastructure, which is good, but maybe we should add NonBinary to the enum and support it?

@Shinigami92
Copy link
Member Author

Should we go ahead and add support for the gender non-binary in this PR? You're setting up the types and infrastructure, which is good, but maybe we should add NonBinary to the enum and support it?

I would do that in v6.2
This is just a bug fix for now, features can be added later

@ST-DDT ST-DDT requested a review from a team March 24, 2022 08:57
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first step. We'll tackle Non Binary support in 6.2 then 👍🏻

@Shinigami92 Shinigami92 merged commit 7675abe into main Mar 24, 2022
@Shinigami92 Shinigami92 deleted the fix-name-module-gender branch March 24, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants