Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize code styles #818

Closed
ST-DDT opened this issue Apr 8, 2022 · 10 comments
Closed

Formalize code styles #818

ST-DDT opened this issue Apr 8, 2022 · 10 comments
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent wontfix This will not be worked on
Milestone

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Apr 8, 2022

Clear and concise description of the problem

Currently it is not clear how some features should be implemented.

Suggested solution

It would be nice if there was a document that explains the code styles/guidelines.

Alternative

No response

Additional context

No response

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 8, 2022
@ST-DDT ST-DDT added this to the v6 - Non-Breaking Changes milestone Apr 8, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Apr 8, 2022

Where would we put this information optimally?

CONTRIBUTING.md or our docs?

@ST-DDT
Copy link
Member Author

ST-DDT commented Apr 8, 2022

See also: #806 - Naming policy for boolean options

@import-brain
Copy link
Member

Where would we put this information optimally?

CONTRIBUTING.md or our docs?

Perhaps both places?

@Shinigami92
Copy link
Member

When docs are written in two places decoupled from each other, one will fast get outdated and ignored. I would like to have one source of truth.

@Shinigami92
Copy link
Member

Started a G-Docs: https://docs.google.com/document/d/1rOevJnJcUi5wmjS1ZWMjmsQME9w5pj94oFriFH-9Fq0/edit#
Access needs to be granted manually

@ST-DDT
Copy link
Member Author

ST-DDT commented Apr 8, 2022

Where would we put this information optimally?
CONTRIBUTING.md or our docs?

Perhaps both places?

Maybe we could generate/include the docs page from the CONTRIBUTING.md.

@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 8, 2022

@since is required now. #1337

@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 26, 2022

The jsdocs part will be handled here: #1397

@xDivisionByZerox
Copy link
Member

What is missing for this issue to be considered "done"?

Most of our code styles are enforced by eslint anyway. If we want a mandatory code style, we should configure a rule that handles that.

@matthewmayer
Copy link
Contributor

I agree this is too generic to be useful and should be closed

@xDivisionByZerox xDivisionByZerox added wontfix This will not be worked on and removed s: accepted Accepted feature / Confirmed bug labels Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent wontfix This will not be worked on
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants