fix: dont log deprecations on startup #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
c: bug
Codecov Report
@@ Coverage Diff @@
## main #857 +/- ##
==========================================
- Coverage 99.35% 99.34% -0.02%
==========================================
Files 1922 1922
Lines 183052 183057 +5
Branches 900 903 +3
==========================================
- Hits 181878 181860 -18
- Misses 1118 1141 +23
Partials 56 56
|
pkuczynski
previously approved these changes
Apr 20, 2022
ST-DDT
reviewed
Apr 20, 2022
ST-DDT
added
p: 2-high
|
AFAICT We haven't released this bug yet, so there is no need for a hotfix release. |
I set that to p3 cause it's blocking us from releasing a v6.2.0, but I'm okay with any prio anyways 🤷 |
ST-DDT
approved these changes
Apr 21, 2022
import-brain
approved these changes
Apr 21, 2022
ST-DDT
deleted the
856-deprecation-messages-are-logged-while-accessing-faker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.