Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option property to provide custom circumferences in address.nearbyGPSCoordinate #878

Open
Shinigami92 opened this issue Apr 26, 2022 · 4 comments
Labels
c: feature Request for new feature m: location Something is referring to the location module p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Milestone

Comments

@Shinigami92
Copy link
Member

Shinigami92 commented Apr 26, 2022

Clear and concise description of the problem

Currently address.nearbyGPSCoordinate is hardly based on earth, but we can change that simply by provide the possibility to provide a custom circumference given by the user.

// TODO @Shinigami92 2022-04-26: Provide an option property to provide custom circumferences.
const kmPerDegree = 40_000 / 360; // in km/°

Suggested solution

nearbyGPSCoordinate(
  coordinate?: [latitude: number, longitude: number],
  options: {
    radius: number = 10,
    isMetric: boolean = false
    circumference: number = 40_000
  }
)

Alternative

No response

Additional context

No response

@xDivisionByZerox
Copy link
Member

Is this really needed? I mean GPS Coordinates should be based on Earth's geometric data, shouldn't they?

@Shinigami92
Copy link
Member Author

Maybe the function should even not include GPS just nearbyCoordinate, as it has nothing todo with GPS 🤷

@ST-DDT ST-DDT added this to the vFuture milestone Apr 26, 2022
@xDivisionByZerox
Copy link
Member

That sounds more reasonable

@import-brain import-brain added c: feature Request for new feature p: 1-normal Nothing urgent and removed s: pending triage Pending Triage labels Apr 26, 2022
@xDivisionByZerox xDivisionByZerox added the m: location Something is referring to the location module label Jul 29, 2022
@ST-DDT ST-DDT added the s: waiting for user interest Waiting for more users interested in this feature label Oct 6, 2022
@matthewmayer matthewmayer added s: waiting for user interest Waiting for more users interested in this feature and removed s: waiting for user interest Waiting for more users interested in this feature labels Apr 28, 2024
Copy link

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: location Something is referring to the location module p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Projects
No open projects
Status: Todo
Development

No branches or pull requests

5 participants