feat: support locale definitions directly from faker.fake #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 1957 1957
Lines 209797 209810 +13
Branches 885 890 +5
=======================================
+ Hits 209084 209097 +13
Misses 693 693
Partials 20 20
|
Shinigami92
previously approved these changes
Apr 28, 2022
Shinigami92
modified the milestones:
v6.3 - Next Minor,
v7.0 - Next Minor,
v7 - Current Major
ST-DDT
force-pushed
the
feature/fake-with-locale-definitions
branch
from
c900f75
to
2eb85de
Compare
Shinigami92
reviewed
May 3, 2022
ST-DDT
force-pushed
the
feature/fake-with-locale-definitions
branch
from
8c5e46f
to
9bd73b4
Compare
Shinigami92
approved these changes
May 6, 2022
pkuczynski
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
fake('{{<pattern>}}')fake.<pattern>()Now
fake('{{<pattern>}}')faker.<pattern>()faker.random.arrayElement(faker.definitions.<pattern>)