Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated arrayElement calls #903

Merged
merged 1 commit into from May 2, 2022

Conversation

Shinigami92
Copy link
Member

close #902

@Shinigami92 Shinigami92 requested a review from a team as a code owner May 2, 2022 15:34
@Shinigami92 Shinigami92 self-assigned this May 2, 2022
@Shinigami92 Shinigami92 added the c: bug Something isn't working label May 2, 2022
@Shinigami92 Shinigami92 requested a review from a team May 2, 2022 15:34
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #903 (495b766) into main (4efaff9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #903   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files        1959     1959           
  Lines      211067   211067           
  Branches      910      910           
=======================================
  Hits       209821   209821           
  Misses       1188     1188           
  Partials       58       58           
Impacted Files Coverage Δ
src/random.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 requested a review from a team May 2, 2022 15:44
@Shinigami92 Shinigami92 enabled auto-merge (squash) May 2, 2022 15:44
@Shinigami92
Copy link
Member Author

@rota-rossi seems like all the other maintainers are currently unavailable.
So sorry if this will be fixed tomorrow, because could be that I'm already sleeping when they approve.
But as this is only a annoying warning message, it just can be ignored and it is not really urgent that it will be fixed immediately.
Maybe someone will also find other bugs that need a hotfix, so maybe it is good that we need to wait a bit 🤷

@Shinigami92 Shinigami92 merged commit 42d6795 into main May 2, 2022
@ST-DDT ST-DDT deleted the fix-usage-of-array-element branch May 2, 2022 18:17
@xDivisionByZerox xDivisionByZerox added the m: random Something is referring to the random module label Aug 26, 2022
@ST-DDT ST-DDT added this to the v6.3 - Next Minor milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working m: random Something is referring to the random module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation message before refactoring - arrayElement()
4 participants