Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fakerbot not searching namespace #36

Closed
akabiru opened this issue Jul 25, 2019 · 2 comments
Closed

Fakerbot not searching namespace #36

akabiru opened this issue Jul 25, 2019 · 2 comments

Comments

@akabiru
Copy link
Owner

akabiru commented Jul 25, 2019

Example1:

C:\Users\richard.bulger>faker search beer -v

Sorry, we couldn't find a match 😢


C:\Users\richard.bulger>faker search yeast -v
Faker
└── yeast=> 5526 - Brettanomyces lambicus
Faker
├── as_you_like_it=> I like this place and willingly could waste my time in it.
└── as_you_like_it_quote=> Can one desire too much of a good thing?.

Note that the first result for beer returns nothing. But the second for yeast, which is a method of beer does. (Also note that the namespace name isn't shown in the result tree, which I've raised in #1565 )

Also, in the second result, you can see it also returns irrelevant results from the Shakespeare namespace. Not sure why.

Example2:

C:\Users\richard.bulger>faker search simpsons -v
Faker
└── i_groups=> Two Two

Doesn't return any simpons namespace stuff, but returns a Kpop one...

From: faker-ruby/faker#1566

@akabiru akabiru mentioned this issue Jul 25, 2019
5 tasks
@bpleslie
Copy link
Contributor

I'm able to reproduce this search issue. I'll dig in and report back 👍

@bpleslie
Copy link
Contributor

This issue is resolved by the work in #38

@akabiru akabiru closed this as completed Jul 26, 2019
@akabiru akabiru mentioned this issue Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants