Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Add Code Level YARD Documentation 📖 #35

Merged
merged 4 commits into from
Aug 9, 2019
Merged

chore(docs): Add Code Level YARD Documentation 📖 #35

merged 4 commits into from
Aug 9, 2019

Conversation

akabiru
Copy link
Owner

@akabiru akabiru commented Jul 15, 2019

Description

Although this is a relatively tiny library, it's can be difficult to reference aspects of it especially after a while.

Furthermore, given this is an open-source library, I'd like to make it easier for new contributors to walk through the code.

@akabiru akabiru self-assigned this Jul 15, 2019
@akabiru akabiru marked this pull request as ready for review July 25, 2019 14:58
@akabiru akabiru modified the milestone: 0.5.0 Release Jul 31, 2019
@akabiru akabiru requested review from bpleslie and vbrazo August 7, 2019 00:42
@akabiru
Copy link
Owner Author

akabiru commented Aug 8, 2019

Any thoughts on this one @vbrazo @bpleslie ? 🙂

Copy link
Contributor

@bpleslie bpleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs FTW! 📚

Copy link
Collaborator

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We also need this for the faker gem and there is an open PR there that will be merged soon.

@akabiru akabiru merged commit ba70ce2 into akabiru:master Aug 9, 2019
@akabiru akabiru deleted the chore/documentation branch August 9, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants