Faker::Internet::fix_umlauts(String) does not clear all special characters

[jensb]

Hello,

fix_umlauts is currently implemented this way:

  def fix_umlauts(string)
    string.gsub(/[äöüß]/i) do |match|
        case match.downcase
            when "ä" 'ae'
            when "ö" 'oe'
            when "ü" 'ue'
            when "ß" 'ss'
        end
    end
  end

This should be extended so that characters like é, â, ç etc. are also replaced with their respective non-accented variants. E.g.

  def fix_umlauts(string)
    string.gsub(/[äöüß]/i) do |match|
        case match.downcase
            when "ä" 'ae'
            when "ö" 'oe'
            when "ü" 'ue'
            when "ß" 'ss'
        end
    end
    string.parameterize     # requires Rails ActiveSupport, however
  end

[jensb]

PS: related discussion: http://stackoverflow.com/questions/225471/how-do-i-replace-accented-latin-characters-in-ruby

This is not about pronounciation or meaning, however - the problem is that currently Faker::Internet.domain_name and .email create strings which are not valid, because in email addresses at least, non-ASCII strings are forbidden (and domain names would need to be punycoded).

[ryanhageman]

I tried to recreate this issue with Faker::Internet.email and the characters like é å ∑ ø were stripped out of the string.

Though this isn't a substitution, it does remove the offending forbidden characters.

Is this resolved, or would it be better to implement something like:

[1] pry(main)> I18n.transliterate("skägget i brevlådan")
=> "skagget i brevladan"

[2] pry(main)> I18n.transliterate("Esta cañón.")
=> "Esta canon."

[bpleslie]

I think this can be closed now.