Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Request.headers #1262

Open
kgriffs opened this issue May 12, 2018 · 1 comment
Open

Rework Request.headers #1262

kgriffs opened this issue May 12, 2018 · 1 comment

Comments

@kgriffs
Copy link
Member

kgriffs commented May 12, 2018

To make the Request.headers property more useful for the common use case of proxying requests to an upstream service, let's return a list of tuples instead of a dict. This is obviously a breaking change, but easily worked around by the caller simply instantiating a dict with the results.

Furthermore, we should take the opportunity to return capitalized headers vs. all-upper-case (for parity with #578. We can use a lookup dict for standard/common headers to ensure this does not cause a significant performance degradation, and only fall back to a slower method for non-standard headers.

All the docs, including the tutorial, will need to be checked for any references to the 1.x behavior that may need to be updated for this breaking change.

@kgriffs kgriffs added this to the Version 2.0 milestone May 12, 2018
@kgriffs kgriffs added needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! and removed good first issue labels May 13, 2018
@steven-upside
Copy link
Contributor

@kgriffs I was thinking about taking this one on, but this seems closely related to #578 which just moved to in-progress. Would it be better to pick something else up to avoid conflicting changes?

@kgriffs kgriffs added needs-decision and removed needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! labels Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants