Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagerduty config in charts not matching with Sidekick commit related to Issue#197 #233

Closed
rahulroy1 opened this issue May 30, 2021 · 1 comment
Assignees
Labels
kind/bug Something isn't working

Comments

@rahulroy1
Copy link

rahulroy1 commented May 30, 2021

Hi,
As per Issue#197 (falcosecurity/falcosidekick#197) and related commit https://github.com/falcosecurity/falcosidekick/pull/200/commits,
the latest PagerDuty handler code uses only "RoutingKey", instead of the earlier set of config parameters like apiKey, service etc.

However, in the values.yaml present in the Helm repo (https://github.com/falcosecurity/charts/tree/master/falco), still the old config parameters for PagerDuty are there and the new RoutingKey is not referred.

As a result, setting RoutingKey using
--set falcosidekick.config.Pagerduty.RoutingKey= doesn't show PagerDuty as the output for Sidekick.

Expected behavior
The Helm repo for falcosecurity/charts/sidekick should have the latest config parameter - RoutingKey

@rahulroy1 rahulroy1 added the kind/bug Something isn't working label May 30, 2021
@Issif Issif self-assigned this Jul 28, 2021
@Issif
Copy link
Member

Issif commented Sep 5, 2021

Hello,

I forgot this issue for a while, sorry. The configuration has been updated now, the RoutingKey value is now available. See:

routingkey: ""

Regards,

@Issif Issif closed this as completed Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants