Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error helm install falcosidekick (chart 0.5.10) #441

Closed
lepsusx opened this issue Jan 10, 2023 · 13 comments
Closed

Error helm install falcosidekick (chart 0.5.10) #441

lepsusx opened this issue Jan 10, 2023 · 13 comments
Labels
kind/bug Something isn't working

Comments

@lepsusx
Copy link

lepsusx commented Jan 10, 2023

Describe the bug

Error helm install falcosidekick

helm repo add falcosecurity https://falcosecurity.github.io/charts
helm repo update
helm install falcosidekick falcosecurity/falcosidekick --set webui.enabled=true
Error: INSTALLATION FAILED: YAML parse error on falcosidekick/templates/deployment-ui.yaml: error converting YAML to JSON: yaml: line 36: could not find expected ':'

or

helm install falco falcosecurity/falco --set falcosidekick.enabled=true --set falcosidekick.webui.enabled=true -n falco
Error: INSTALLATION FAILED: YAML parse error on falco/charts/falcosidekick/templates/deployment-ui.yaml: error converting YAML to JSON: yaml: line 36: could not find expected ':'

Environment

  • Falco version:
NAME                                    	CHART VERSION	APP VERSION                       	DESCRIPTION
falcosecurity/falco                     	2.4.5        	0.33.1                            	Falco                                             
falcosecurity/falco-exporter            	0.9.1        	0.8.0                             	Prometheus Metrics Exporter for Falco output ev...
falcosecurity/falcosidekick             	0.5.10       	2.27.0                            	Connect Falco to your ecosystem   
  • System info:

Kubernetes v1.23.6
containerd.io 1.5.11
helm v3.10.3

  • Cloud provider or hardware configuration:
  • OS: Ubuntu 20.04 LTS

Linux k8sdemreprod1001 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

  • Installation method:

From source
Additional context
I have not found the minimum requirements and I know helm in a basic way, additionally I tried with another namespace.

@lepsusx lepsusx added the kind/bug Something isn't working label Jan 10, 2023
@ckotzbauer
Copy link

ckotzbauer commented Jan 10, 2023

Same here, there is a space missing for the new args from the ui-deployment (info and admin:admin):

          args:
            - "-r"
            - xy-falcosidekick-ui-redis:6379
            - "-l"
            -"info"
            - "-u"
            -admin:admin
          ports:
            - name: http
              containerPort: 2802
              protocol: TCP

However, the template itself looks good to me.

@Issif
Copy link
Member

Issif commented Jan 10, 2023

I'm fixing right now

@Issif
Copy link
Member

Issif commented Jan 10, 2023

@lepsusx @ckotzbauer if you use directly the falcosidekick chart, it's fixed, if you use the falco one, it will be in few minutes. sorry.

@ckotzbauer
Copy link

Thanks @Issif!
This fix worked, but I discovered another bug: The 2.1.0 image of falcosidekick was released without the "v" prefix. https://hub.docker.com/r/falcosecurity/falcosidekick-ui/tags

@Issif
Copy link
Member

Issif commented Jan 10, 2023

It's not a bug, it's like that since the beginning, I thought it wasn't mandatory in semver method and I started without and I think it's better for the users to no change that.

@ckotzbauer
Copy link

/api/v1/healthz is used for liveness- and readinessProbes. I receive a 401 here after the update. Is this endpoint also authenticated now (regarding the user and password which was added to the chart)?

@ckotzbauer
Copy link

It's not a bug, it's like that since the beginning, I thought it wasn't mandatory in semver method and I started without and I think it's better for the users to no change that.

But then the "v" has to be removed from this chart. Otherwise the image can't be pulled.

@Issif
Copy link
Member

Issif commented Jan 10, 2023

Sorry, I thought we were talking about sidekick and not the ui. Let me check.

@Issif
Copy link
Member

Issif commented Jan 10, 2023

@ckotzbauer the image with the v tag is pushed on Dockerhub https://hub.docker.com/layers/falcosecurity/falcosidekick-ui/v2.1.0/images/sha256-8d6c2f8b93e3a38c5d7728c9b6f2c9d3b99264de54e014eb5d5cd271c3e646ad?context=explore

And the healthcheck endpoint is now unauthenticated

@ckotzbauer
Copy link

Thanks @Issif for your very quick response. I'll appreciate that!

@Issif
Copy link
Member

Issif commented Jan 10, 2023

I'm happy you use my projects, your feedback is really valuable to me. Thanks.

@Issif
Copy link
Member

Issif commented Jan 10, 2023

@lepsusx is that ok for you? can you close this issue when it is please

@lepsusx
Copy link
Author

lepsusx commented Jan 10, 2023

it's ok, thanks @Issif !!

@lepsusx lepsusx closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants