Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected rules from "rule-updates-2018-11.v1" are missing in v0.13.0 #489

Closed
legal90 opened this issue Dec 27, 2018 · 4 comments
Closed

Comments

@legal90
Copy link

legal90 commented Dec 27, 2018

The changelog of v0.13.0 says:

New rules Launch Package Management Process in Container, Netcat Remote Code Execution in Container, and Lauch Suspicious Network Tool in Container look for running various suspicious programs in a container. [#461]

However, these rules didn't end up in the dev branch and were not released in v0.13.0.
I guess, that happened because you've merged the #455 (rule-updates-2018-11.v1 to dev) before you merged #461 (kh_add-process-rules to rule-updates-2018-11.v1).
So, the changes of #461 got lost when you deleted the branch rule-updates-2018-11.v1.

Should I open the new PR to bring these changes to dev ?

cc: @mstemm

@mstemm
Copy link
Contributor

mstemm commented Dec 27, 2018

Well, that was silly. I'll create a new PR to reflect the changes in #461. Thanks for pointing this out!

@mstemm
Copy link
Contributor

mstemm commented Dec 27, 2018

New PR #490 contains cherry-picked commits from #461.

@mstemm
Copy link
Contributor

mstemm commented Dec 28, 2018

PR Merged, so closing.

@mstemm mstemm closed this as completed Dec 28, 2018
@legal90
Copy link
Author

legal90 commented Dec 28, 2018

@mstemm Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants