Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gVisor engine crashes with non-hex container IDs #1602

Closed
LucaGuerra opened this issue Dec 22, 2023 · 1 comment · Fixed by #1612
Closed

gVisor engine crashes with non-hex container IDs #1602

LucaGuerra opened this issue Dec 22, 2023 · 1 comment · Fixed by #1612
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@LucaGuerra
Copy link
Contributor

LucaGuerra commented Dec 22, 2023

Describe the bug

This issue comes from the analysis in: falcosecurity/falco#2897 . Currently, the gVisor engine crashes if a non-hex container ID is used.

How to reproduce it

Example:

# create a container bundle
mkdir redis
mkdir redis/rootfs
docker pull redis
docker create --name tempredis redis
docker export tempredis | tar -C redis/rootfs -xf -
docker rm tempredis
cd ./redis/
runc spec
cd ..
# run a runsc sandbox with a non-hex id
sudo runsc -platform=systrap -file-access=shared -host-uds=open -overlay2=none -directfs -dcache=0 --cpu-num-from-quota --pod-init-config=/etc/docker/runsc_falco_config.json -debug-log=/tmp/runsc/ -debug -strace run -bundle redis/ my_container_id

Meanwhile, run Falco (or any libs client) with gVisor integration enabled.

Expected behaviour

Falco should not crash.

Screenshots

Environment

libs 0.14.0

Additional context

@LucaGuerra LucaGuerra added the kind/bug Something isn't working label Dec 22, 2023
@Andreagit97 Andreagit97 added this to the 0.14.1 milestone Jan 8, 2024
@LucaGuerra
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants