Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: Introduce the in-repo-config for evolution repo #841

Closed
wants to merge 5 commits into from
Closed

wip: Introduce the in-repo-config for evolution repo #841

wants to merge 5 commits into from

Conversation

maxgio92
Copy link
Member

@maxgio92 maxgio92 commented Sep 6, 2022 •
edited
Loading

This PR introduces the in_repo_config, only for evolution repo for now.

Moreover, it adds a presubmit prowjob config check, for PR opened in the evolution repository. This is to alert evolution contributors on job configuration errors.

In detail, the jobs are expected in the evolution repo under the /.prow/ directory.

Fixes #840

@maxgio92
feat: configure in_repo_config for evolution repository
07d4d87 
Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
@poiana poiana added the approved label Sep 6, 2022
@maxgio92 maxgio92 changed the title wip: Issue/840 wip: Introduce the in-repo-config for evolution repo Sep 6, 2022
@maxgio92
feat: run prowjob check before prs submission in evolution repo
665ef27 
Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
This was referenced Sep 6, 2022
Closed
Open
@maxgio92 maxgio92 mentioned this pull request Sep 8, 2022
Closed
@zuc
Copy link
Member

zuc commented Sep 8, 2022

I think we should also provide support for autobump for in-repo job definitions.
cc @maxgio92

/hold

@maxgio92
ci(config/jobs): run prow config check on evolution only with changes
b122817 
Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
@maxgio92
Copy link
Member Author

maxgio92 commented Sep 8, 2022

Ok @zuc, let's find a solution to that. Thanks

@poiana poiana added size/L and removed size/M labels Sep 9, 2022
@poiana
Copy link
Contributor

poiana commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maxgio92
refactor(images/autobump): make bump of component and config optional
36768f8 
Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
@maxgio92 maxgio92 force-pushed the issue/840 branch 2 times, most recently from c680695 to 8dbc5ca Compare September 9, 2022 18:55
@maxgio92
ci(autobump): add autobump for evolution jobs
ba53927 
Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
@maxgio92
Copy link
Member Author

maxgio92 commented Sep 9, 2022 •
edited
Loading

Hey @zuc please take a look at the last two commits (36768f8 and ba53927).

They aim to:

WDYT?

@poiana
Copy link
Contributor

poiana commented Feb 13, 2023

@maxgio92: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-images-update-drivers-website ba53927 link true /test build-images-update-drivers-website
build-new-drivers-ubuntu-gke-3-presubmit ba53927 link true /test build-new-drivers-ubuntu-gke-3-presubmit
build-new-drivers-ubuntu-gcp-4-presubmit ba53927 link true /test build-new-drivers-ubuntu-gcp-4-presubmit
build-new-drivers-ubuntu-gke-4-presubmit ba53927 link true /test build-new-drivers-ubuntu-gke-4-presubmit
build-new-drivers-ubuntu-gke-5-presubmit ba53927 link true /test build-new-drivers-ubuntu-gke-5-presubmit
build-images-update-syscalls ba53927 link true /test build-images-update-syscalls
validate-new-drivers-ubuntu-gcp-5-presubmit ba53927 link true /test validate-new-drivers-ubuntu-gcp-5-presubmit
validate-new-drivers-ubuntu-azure-5-presubmit ba53927 link true /test validate-new-drivers-ubuntu-azure-5-presubmit
validate-new-drivers-ubuntu-gcp-3-presubmit ba53927 link true /test validate-new-drivers-ubuntu-gcp-3-presubmit
validate-new-drivers-ubuntu-azure-3-presubmit ba53927 link true /test validate-new-drivers-ubuntu-azure-3-presubmit
validate-new-drivers-ubuntu-generic-3-presubmit ba53927 link true /test validate-new-drivers-ubuntu-generic-3-presubmit
valdiate-new-drivers-ubuntu-generic-5-presubmit ba53927 link true /test valdiate-new-drivers-ubuntu-generic-5-presubmit
validate-new-drivers-ubuntu-generic-4-presubmit ba53927 link true /test validate-new-drivers-ubuntu-generic-4-presubmit
validate-new-drivers-bottlerocket-4-presubmit ba53927 link true /test validate-new-drivers-bottlerocket-4-presubmit
validate-new-drivers-bottlerocket-5-presubmit ba53927 link true /test validate-new-drivers-bottlerocket-5-presubmit
build-images-update-rules-index ba53927 link true /test build-images-update-rules-index
validate-new-drivers-bottlerocket-presubmit ba53927 link true /test validate-new-drivers-bottlerocket-presubmit

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maxgio92
Copy link
Member Author

maxgio92 commented Feb 15, 2023 •
edited
Loading

As discussed with @leogr, @FedeDP, @cappellinsamuele, as the direction is to leverage as much as possible Github Actions for repo-specific jobs, I think it's not worth to introduce in-repo config as of now.

Instead, I'm going to open a PR dedicated only to #840, and one for refactoring of autobumper script (#999)

/close

@poiana
Copy link
Contributor

poiana commented Feb 15, 2023

@maxgio92: Closed this PR.

In response to this:

As discussed with @leogr, @FedeDP, @cappellinsamuele, as the direction is to leverage as much as possible Github Actions for repo-specific jobs, I think it's not worth to introduce in-repo config as of now.

Instead, I'm going to open a PR dedicated only to #840, and one for refactoring of autobumper script.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana closed this Feb 15, 2023
This was referenced Feb 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr left review comments

@jonahjon jonahjon Awaiting requested review from jonahjon

Assignees
No one assigned
Labels
approved dco-signoff: yes do-not-merge/hold do-not-merge/work-in-progress size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move org.yaml to evolution repo
4 participants
@maxgio92 @zuc @poiana @leogr