Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signs will go invisible #12

Closed
Bamuel opened this issue Nov 10, 2015 · 20 comments
Closed

Signs will go invisible #12

Bamuel opened this issue Nov 10, 2015 · 20 comments
Milestone

Comments

@Bamuel
Copy link

Bamuel commented Nov 10, 2015

If you place a sign next to the mine tested it for 1-5 blocks away the sign goes invisble

@falkirks
Copy link
Owner

When the mine resets?

@Bamuel
Copy link
Author

Bamuel commented Nov 13, 2015

yes

@falkirks
Copy link
Owner

This could be a rather hard issue to fix. MineReset serializes the chunks, processes them, and then sets and send them in bulk to the client. If you relog the world, do they reappear?

@Bamuel
Copy link
Author

Bamuel commented Nov 15, 2015

nope.

But i think its a Pocketmine bug

@DaPigGuy
Copy link

This happens with entities too...

@falkirks
Copy link
Owner

This is due to the fact that the chunks are entirely reset and built from scratch. I don't know if there is currently a way to fix this and be thread-safe.

@DaPigGuy
Copy link

Couldn't you just save the tiles and entities and spawn them back in where
they were?

On Sunday, February 21, 2016, Falkirks notifications@github.com wrote:

This is due to the fact that the chunks are entirely reset and built from
scratch. I don't know if there is currently a way to fix this and be
thread-safe.


Reply to this email directly or view it on GitHub
#12 (comment).

@falkirks
Copy link
Owner

Yes. This is definitely possible. But would require another management class in the plugin which would require refactoring.

@falkirks falkirks mentioned this issue Mar 12, 2016
@Muqsit
Copy link

Muqsit commented Apr 10, 2016

@falkirks
Copy link
Owner

@Muqsit That makes sense as that version doesn't work asynchronously.

@mad-hon
Copy link

mad-hon commented Jun 12, 2016

If it's related to whole chunks being reset, then a suitable workaround would be to find chunk boundaries and make sure any signs are placed in chunks not being modified by mine reset. Right?

@falkirks
Copy link
Owner

@mad-hon I don't understand your point. You could cache all entity data and load it back in, but that would be complicated.

@mad-hon
Copy link

mad-hon commented Jun 13, 2016

I mean workaround to suggest to users until this issue is resolved.

@falkirks
Copy link
Owner

@mad-hon Oh, I understand, yes

@yodo226
Copy link

yodo226 commented Dec 19, 2016

still need a solution :/ signs disappearing

@mad-hon
Copy link

mad-hon commented Dec 28, 2016

@anti2canz read my workaround above.
The issue is that MineReset overwrites the whole chunk.
So if you place your sings in other chunk than the one you're modifying with MineReset, you'll be fine.
You can learn about chunks at http://minecraft.gamepedia.com/Chunk

@yodo226
Copy link

yodo226 commented Dec 29, 2016

@mad-hon oh thanks got it no wonder the disappearing distance varies

@falkirks falkirks mentioned this issue Apr 12, 2017
@falkirks falkirks added this to the Version 3.0 milestone Apr 17, 2017
@falkirks
Copy link
Owner

I have attempted to add this, but I am getting very strange errors.

@dktapps
Copy link
Contributor

dktapps commented Apr 23, 2017

This issue should be resolved by pmmp/PocketMine-MP@d2efcee .

@falkirks
Copy link
Owner

@dktapps Thanks! I will see what I can do to avoid dropping support for earlier versions.

falkirks added a commit that referenced this issue Apr 24, 2017
And also add permission nodes to commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants