Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library doesn't use timeout in all requests library function calls #154

Closed
E-ThanG opened this issue May 10, 2021 · 6 comments
Closed

Library doesn't use timeout in all requests library function calls #154

E-ThanG opened this issue May 10, 2021 · 6 comments

Comments

@E-ThanG
Copy link

E-ThanG commented May 10, 2021

This library doesn't include the timeout attribute when self.ise.get() is called. Timeout is only used for self.ise.request() in the internal _request() function. That function also includes an earlier call to self.ise.get() without a timeout before calling self.ise.request() with a timeout. Thus, the configured timeout seldom has any effect that I have seen.

The argument "timeout=self.timeout" should be added to every self.ise.get() call

@falkowich
Copy link
Owner

Hi,
I
f you want to I am really thankful for help :)
So if you have an idea or anything already done, please send a PR over.

For the moment I can't commit to this, but I will put this in the famous ToDo :)

--
Regards Falk

@E-ThanG
Copy link
Author

E-ThanG commented May 27, 2021

Done but not tested. Do you want me submit a PR into a specific branch?

@falkowich
Copy link
Owner

Hi,

I have synced up dev now.
It would be great if you could make the PR to dev?

--
Regars Falk

@E-ThanG
Copy link
Author

E-ThanG commented May 31, 2021

Submitted a PR to dev.

I commented in the request, timeouts used to be there in older code but were removed in the latest release. Also, I broke the changes into 2 commits. One adds timeouts and the other does some reformatting. Just in case you don't like the formatting changes.

@falkowich
Copy link
Owner

I will check this out as soon as #164 is done

And I am sorry for taking so much time with this..

--
Regards Falk

@falkowich falkowich added this to the 0.2.0 milestone Sep 30, 2021
@falkowich
Copy link
Owner

Thanks!

Merged and tested in #174.
Timeouts are now included.

--
Regards Falk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants