New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use external miniz & pugixml #99
Comments
Hi, thanks for the feedback. This is a good idea. I'd propose to simplify it a bit by making it something like |
I have build a ZLIB switch into my fork, but only for the code, I am not so firm with cmake.. |
If you're only using a preprocessor definition then cmake is quite easy to update. First you'd need a cmake variable somewhere near the top of the file:
which lets the user configure it to true or false. Then:
to add the preprocessor defs. You'll also need to tell cmake to find the libraries (probably the most complicated part depending on the library support for cmake)
and then finally tell cmake where the include dirs and libraries to link are
Although the exact include/lib variables will depend on how cmake finds them. As for meson, I have no idea, I've never used it 😅 |
ok I will try this out but will take some time |
The standard way to do this in meson is actually to delete:
You'd then use See https://mesonbuild.com/Wrap-dependency-system-manual.html |
Oh, OK. I'm not really familiar with meson, support was kindly provided by @KingDuckZ and I modified it as best I knew how to work with this update. Thanks for the tip! |
It would be nice to be able to use externally installed miniz & pugixml, vendoring is bad for package managers (ODR violation).
miniz
&pugixml
files in specific folders (vendor/miniz
&vendor/pugixml
for example)#include <pugixml.hpp>
instead of#include "detail/pugixml.hpp"
(this modification is tedious for package managers)TMXLLITE_EXTERNAL_MINIZ
andTMXLLITE_EXTERNAL_PUGIXML
The text was updated successfully, but these errors were encountered: