Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Validate whether the user is a local network user and only allow log in locally #123

Closed
1 task done
Kreach37 opened this issue Jun 2, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Kreach37
Copy link

Kreach37 commented Jun 2, 2022

Description

I can login with an user that is only for local use only using external URL.

Jellyseerr was set up using jellyfin local ip.

"Allow remote connections to this server" is uncheck in jellyfin config for the user.

I'm running the develop branch on docker and have set the external URL to fix profile picture and play on jellyfin button.

This is a security concern for my use case since that user doesn't have a password.

What I would like:

  1. ability to use that user locally when accessing jellyseerr from my local ip.
  2. not being able to access jellyseerr from external URL with that user.

Possible quick fix:
Use external URL for the login process, that would resolve my security concern but not allow local user when on local network.

I will add a password to the user for now!

Version

5298e5f

Steps to Reproduce

  1. setup a local user in jellyfin with or without a password
  2. login with the local user on jellyseerr using external URL

Code of Conduct

  • I agree to follow Overseerr's Code of Conduct
@Fallenbagel
Copy link
Owner

Fallenbagel commented Jun 2, 2022

I'm not sure I understand but I'm guessing what you want is when the user with no password tries to log in, not allow him to be logged in?

You could do that by going into jellyseerr settings and turning off enable new jellyfin login. And if the user already exists you can remove him from jellyseerr. That way that user won't be able to log in, and you can have everyone else imported using the import user button and for that user you can have a local user in jellyseerr.

Previously we had it so that even if you did not have a password you could not log in to jellyseerr with no password, but due to popular request we added in the ability to log in to jellyseerr without password.

@Kreach37
Copy link
Author

Kreach37 commented Jun 2, 2022

Thanks for the suggestion!

My problem was that using an external Url lets say jellyseerr.domain.com, I should not be able to login with my username "NoPassword", since jellyfin (jellyfin.domain.com) would not allow it, because that user is local only.

jellyfin settings in the dashboard

The fact that this user has no password should not matter, any user mark as local in jellyfin should not be allowed to be use not locally.

@Fallenbagel
Copy link
Owner

Fallenbagel commented Jun 3, 2022

Ohh I think I get it. Currently it does not validate whether the user is local or remote. Have to try and see how to implement that through api

Let me change the tag to feature request

Meanwhile you can use my suggestion where new jellyfin log in is disabled and removing that user from jellyseerr user list and just creating a local user for that user only

@Fallenbagel Fallenbagel changed the title Login possible with local user when using external URL [Feature Request] Validate whether the user is a local network user and only allow log in locally Jun 3, 2022
@Fallenbagel Fallenbagel added the enhancement New feature or request label Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants