-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for editing the position of an existing location #306
Comments
On desktop, I suggest extending the current UX by making the map movable, as when during adding a new location. Other locations should be visible (like in #393) but not the old position of the location being edited. On mobile, I suggest extending the current UX by prepending a step, just like adding a new location has two steps. When editing, the user will first confirm the position of the existing location or move the marker, mock-up: As an aside, do we want to make the title of the second step "New location details" and "Edit location details"? |
@wbazant Following the same flow as when adding a location is probably the best place to start. (Though I wonder whether forcing two steps will feel too cumbersome, and better thus to link to edit-location-position from the main edit-location form). Do you think the mobile view should also include two markers, one for old and one for new position? Regarding naming, my preference is always to use text that already exists on the website or mobile apps, since we have translations for these, or at least as simple as possible so that translations are easier. So e.g. "Add location", "Edit location" from https://github.com/falling-fruit/falling-fruit-mobile/blob/main/www/locales/en.json. |
Yes, I think it'd be nice if the same edit location component worked on both desktop and mobile for editing the location! |
A feature of the current website that is not yet supported is the ability to change the map position of an existing location.
The text was updated successfully, but these errors were encountered: