Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for editing the position of an existing location #306

Open
ezwelty opened this issue Apr 24, 2022 · 3 comments
Open

Add support for editing the position of an existing location #306

ezwelty opened this issue Apr 24, 2022 · 3 comments
Labels
enhancement New feature request
Milestone

Comments

@ezwelty
Copy link
Collaborator

ezwelty commented Apr 24, 2022

A feature of the current website that is not yet supported is the ability to change the map position of an existing location.

@ezwelty ezwelty added enhancement New feature request P1 labels Apr 24, 2022
@ezwelty ezwelty changed the title Add support for editing an existing location Add support for editing the position of a location May 19, 2022
@ezwelty ezwelty changed the title Add support for editing the position of a location Add support for editing the position of an existing location May 19, 2022
@ezwelty ezwelty added this to the Beta release milestone Feb 3, 2023
@ezwelty ezwelty removed the P1 label Feb 3, 2023
@wbazant
Copy link
Contributor

wbazant commented Jun 6, 2024

On desktop, I suggest extending the current UX by making the map movable, as when during adding a new location. Other locations should be visible (like in #393) but not the old position of the location being edited.

On mobile, I suggest extending the current UX by prepending a step, just like adding a new location has two steps. When editing, the user will first confirm the position of the existing location or move the marker, mock-up:
Screenshot from 2024-06-06 22-52-03
. The back button in the second step of "edit location" should go to the first step, not back to the map.

As an aside, do we want to make the title of the second step "New location details" and "Edit location details"?

@ezwelty
Copy link
Collaborator Author

ezwelty commented Jun 9, 2024

@wbazant Following the same flow as when adding a location is probably the best place to start. (Though I wonder whether forcing two steps will feel too cumbersome, and better thus to link to edit-location-position from the main edit-location form).

Do you think the mobile view should also include two markers, one for old and one for new position?

Regarding naming, my preference is always to use text that already exists on the website or mobile apps, since we have translations for these, or at least as simple as possible so that translations are easier. So e.g. "Add location", "Edit location" from https://github.com/falling-fruit/falling-fruit-mobile/blob/main/www/locales/en.json.

@wbazant
Copy link
Contributor

wbazant commented Jun 9, 2024

Do you think the mobile view should also include two markers, one for old and one for new position?

Yes, I think it'd be nice if the same edit location component worked on both desktop and mobile for editing the location!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants