This repository has been archived by the owner on Aug 25, 2020. It is now read-only.
removed attributes from Manifest #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these attributes should belong to the application project, not to the library project They cause problems in applications project using that library, e.g.: Attribute application@label value=(@string/appName) from [:features:base] AndroidManifest.xml:51:9-40 is also present at [us.feras.mdv:markdownview:1.1.0] AndroidManifest.xml:13:9-41 value=(@string/app_name). Suggestion: add 'tools:replace="android:label"' to <application> element at AndroidManifest.xml:6:5-157:19 to override. It might be easily fixable with the tools:replace Attribute, but thats more a workaround than a real fix...
andschdk
approved these changes
Dec 6, 2019
|
Would be nice to have this merged so you shouldn't add |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these attributes should belong to the application project, not to the library project
They cause problems in applications project using that library, e.g.:
Attribute application@label value=(@string/appName) from [:features:base] AndroidManifest.xml:51:9-40
is also present at [us.feras.mdv:markdownview:1.1.0] AndroidManifest.xml:13:9-41 value=(@string/app_name).
Suggestion: add 'tools:replace="android:label"' to element at AndroidManifest.xml:6:5-157:19 to override.
It might be easily fixable with the tools:replace Attribute, but thats more a workaround than a real fix...