Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with ReplayMod (Crash on boot) #10

Closed
HRudyPlayZ opened this issue Nov 23, 2022 · 2 comments
Closed

Incompatible with ReplayMod (Crash on boot) #10

HRudyPlayZ opened this issue Nov 23, 2022 · 2 comments

Comments

@HRudyPlayZ
Copy link

Everything's in the title.

@makamys
Copy link

makamys commented Nov 26, 2022

That's because ReplayMod (1.7.10-2.5.2) uses methods that were removed in Mixin 0.8 in its bootstrap code. If you make these changes in ReplayModTweaker, it will work again (but not with Mixin 0.7)

-         if (GlobalProperties.get("mixin.initialised") == null) {
+         if (GlobalProperties.get(Keys.INIT) == null) {
-      platform.addContainer(uri);
+      platform.addContainer(new ContainerHandleURI(uri));

Here's a class with these changes you can drop in the jar (replacing com/replaymod/core/tweaker/ReplayModTweaker.class).

ReplayModTweaker.class.zip

The issue could be solved on GasMix's side by readding those two methods. I don't know if backward compatibility with Mixin 0.7 is a goal though.

@FalsePattern
Copy link
Owner

FalsePattern commented Dec 21, 2022

Fixed in 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants