Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_oidp_metadata assumes that the issuer URL has no path #39

Closed
Clemens-Toegel opened this issue May 7, 2024 · 0 comments · Fixed by #42
Closed

get_oidp_metadata assumes that the issuer URL has no path #39

Clemens-Toegel opened this issue May 7, 2024 · 0 comments · Fixed by #42
Assignees

Comments

@Clemens-Toegel
Copy link

Clemens-Toegel commented May 7, 2024

When having an OpenID Connect issuer with a path (e.g.: https://your.authentik.example.org/application/o/your-app-slug/), the synapse token authenticator can not find the OpenIDProviderMetadata as urljoin strips away the path.

Expected Behavior

get_oidp_metadata respects the given path from the issuer URL

Current Behavior

get_oidp_metadata strips away the path from the URL

Possible Solution

Current implementation:

urljoin(issuer, "/.well-known/openid-configuration"),

Solution:
The urljoin should add the well known part without a trailing slash to avoid stripping the issuer URL:
urljoin(issuer, ".well-known/openid-configuration")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants