Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precise file detection #47

Closed
fan-tom opened this issue Oct 11, 2021 · 0 comments · Fixed by #49
Closed

More precise file detection #47

fan-tom opened this issue Oct 11, 2021 · 0 comments · Fixed by #49

Comments

@fan-tom
Copy link
Owner

fan-tom commented Oct 11, 2021

Currently plugin uses first few characters to detect file type (Github or Bitbucket). But if it doesn't find Bitbucket-specific char sequencief, it asssumes it is Github file. And it becomes wrong assumption if there is long documentation comment header in file, so that first codeowners rule (which is of interest for file type detector) is not in that few first characters.

Actual behaviour: Bitbucket file is detected as being Github one which gives syntactic error

Expected Behaviour: Bitbucket file detected correctly no matter how far first rule is from beginning of a file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant