Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying permittivity with geometric primitives #26

Open
ianwilliamson opened this issue Nov 24, 2018 · 4 comments
Open

Specifying permittivity with geometric primitives #26

ianwilliamson opened this issue Nov 24, 2018 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ianwilliamson
Copy link
Contributor

It would be useful to implement some hooks into a computational geometry package to allow the user to specify an input permittivity distribution (or even the optimization design region) using collections of geometric primitives, e.g. rectangles, circles, etc. The user could also specify transformations of these objects, e.g. rotations, arrays, etc.

This would make it much easier to specify certain types of structures, e.g. waveguide bends, couplers, photonic crystals, ring resonators, etc, compared to the current approach of using conditionals operating directly on the array values.

For example, in my FDFD.jl package I use https://github.com/stevengj/GeometryPrimitives.jl There may be similar packages for python.

@ianwilliamson ianwilliamson added the enhancement New feature or request label Nov 24, 2018
@twhughes
Copy link
Member

twhughes commented Nov 25, 2018

Sounds good to me. We could also define our own, seems simple enough.

In a way, what's in structures.py is a basic template for defining complicated permittivity distributions out some geometric parameters. We could also define a more general geometries.py package that allows users to define basic shapes to construct structures out of.

@twhughes twhughes added the help wanted Extra attention is needed label Dec 7, 2018
@shoyer
Copy link

shoyer commented Dec 14, 2018

scikit-image defines a bunch of these: http://scikit-image.org/docs/dev/api/skimage.draw.html

@twhughes
Copy link
Member

@shoyer This looks really useful, thanks!

When I get some time, I may overhaul the structures.py interface and use these for convenience.

@twhughes
Copy link
Member

@ianwilliamson @momchilmm We can use our shape @primitives for this potentially

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants