Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Add support for RTL locales #1210

Open
ZakariaEsbaiy opened this issue Feb 1, 2017 · 6 comments
Open

Add support for RTL locales #1210

ZakariaEsbaiy opened this issue Feb 1, 2017 · 6 comments

Comments

@ZakariaEsbaiy
Copy link

fancybox cause problems when clicking on images if the website had dirction rtl on body, and the controls and animations are glitchy.

@mjcampagna
Copy link

I can confirm this. Some of what I see when using right-to-left includes:

  • left/right navigation is reversed.
  • images slide into place, then sometimes disappear.
  • some images simply do not appear at all.
  • clicking a thumbnail sometimes loads the wrong image.

Switching my page back to left-to-right, everything functions as expected.

@fancyapps
Copy link
Owner

These glitches were easy to fix by couple of CSS lines (included in the last commit).

But, could you describe what would be needed for full RTL support?
I suspect navigation arrows should be switched places, right? What else?

@ZakariaEsbaiy
Copy link
Author

@fancyapps Yeah I fixed it by adding dir:ltr; to .fancybox-container.
But that just fix the problems not support RTL.
Yeah navigation arrows should be switched places, also the direction of animation, and the caption should go to the right, and the buttons (full screen, close, ...) should go to the left.
Basically everything should switch places, I've worked on a lot of RTL websites, everything should switch places, you can confirm that by checking some RTL websites on themeforest.net
Thank you for the awesome plugin by the way.

@fancyapps fancyapps changed the title issue with dirction rtl Add support for RTL locales Feb 28, 2017
@VadimLu
Copy link

VadimLu commented Mar 21, 2017

Same here..
For example Hebrew/Arabic Langs, Everything goes from right to left..

@alan-zhang-
Copy link

Hi, when arabic website would be supported?

@technilogics
Copy link

when Arabic support will be added, using css i fix directions placement, but image scrolling direction should be reversed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants