Slideshow only moves forward one slide

[kevinp]

Here are the steps to produce the behavior:

1. Visit http://www.rentvillas.com/PropertyPhotos.aspx?Catalog=14428
2. Click on any of the photos to see fancybox.
3. Click play.
4. Slideshow progresses one slide then no longer progresses

Here is the fancybox initialization from common.js

           $.fancybox(items, {
                'padding': 0,
                'nextEffect': 'fade',
                'prevEffect': 'fade',
                'openSpeed': 'normal',
                'closeSpeed': 'fast',
                'playSpeed': 2000,
                'index': indexClicked,
                'type': 'image',
                'helpers': {
                    title: { type: 'outside' },
                    buttons: {},
                    thumbs: { width: 100, height: 70 }
                },
                'afterShow': function () {
                    $(".fancybox-outer").bind("contextmenu", function (e) {
                        return false;
                    });
                    $(".fancybox-wrap").addClass("addthis_shareable");
                    addthis.update('config', 'services_overlay', 'facebook,twitter,email,print,more');
                }
            });

[fancyapps]

What if you would comment out addthis? I used your snippet without addthis and it worked for me fine.

[kevinp]

Thanks for your response. Sorry I should not have included the addthis code while debugging the problem. I've removed it from the sample, however the problem remains. The slideshow progresses one frame and stops. I tried removing the 'afterShow' configuration entirely and the slideshow still won't play past the second frame of the slideshow. Please let me know if you have any other ideas for debugging the issue.

[fancyapps]

First, maybe try updating to the latest - https://github.com/fancyapps/fancyBox/zipball/master

[kevinp]

Thanks for your reply. I updated to the latest release. The slideshow still only moves forward one slide. Kevin

-----Original Message-----
From: Jānis Skarnelis [mailto:reply@reply.github.com]
Sent: Tuesday, February 28, 2012 1:18 AM
To: Kevin Pidduck
Subject: Re: [fancyBox] Slideshow only moves forward one slide (#160)

First, maybe try updating to the latest - https://github.com/fancyapps/fancyBox/zipball/master

---

Reply to this email directly or view it on GitHub:
#160 (comment)

[kevinp]

It appears that the latest release breaks the gallery functionality. It created two rows of blank thumbnails, and users were unable to progress using the arrows. Therefore I had to revert back to the previous version.

[JFKDIAZ]

@kevinp : Fancybox v2.x code clearly specifies that you should use jQuery v1.6 or later. In your demo site you are using jQuery v1.4.2. Try upgrading your jQuery version before assuming there is a bug there.

[fancyapps]

Yes, older jQuery versions had a bug that breaks slideshow (related to namespaced events).

[kevinp]

DOH. I'm really sorry. I had confused the version numbers of jquery-ui with jquery. Thank you for your help. The issue is now resolved.

[Iphitos]

This issue might need to be reopened.

I tried the button helper on http://fancyapps.com/fancybox/ with MSIE 9.0.12, Google Chrome v24.0.1312.52 m, Firefox 18.0, Opera 12.12 and Safari (Win) v5.1.7.

The slideshow will only progress one slide then it will stop.

[walkerjack]

The issue definitely needs to be reopened. I just go to the official website
http://fancyapps.com/fancybox/#examples
and the slideshow button doesn't go beyond the first image.
I checked at several computers and different browsers (FF18.0.1, Chrome 23.0.1271.91 m for sure). Please, help!!

[dn00b]

Indeed. The same problem here. This needs to be addressed. Is it a jQuery bug?

[ndunand]

I posted this in the other issue ( #493 ) but just to be sure it goes through:
[...] on line 435 of jquery.fancybox.js we have setTimeout instead of setInterval – and of course on line 429 we also have clearTimer instead of clearInterval.
I had the same problem and changing those two lines solved it.

[dn00b]

Great! I didn't knew about the other thread. This fixes the problem. Thanks!

[dn00b]

It does fixes the problem in Firefox, Opera and Chrome, but not in IE. Any thoughts about that?

[ndunand]

What IE version are you using? I just tested it on IE9 and it works fine.

[dn00b]

OK, must have done something wrong. It's now working in IE as well. Thanks ndunand!

[qwertykeith]

Hi ... i still have this problem on all the browsers i tried despite using the latest code from here

i'm using jquery-1.9.0 (with jquery-migrate-1.1.0)

i don't get any javascript errors, but the slideshow only does one transition before stopping

[ndunand]

@qwertykeith did you try my fix? I have tried it with jQuery 1.9.0 without the migrate plugin and it works fine.

[dn00b]

I did what ndunand recommended and it solved my problem:

"[...] on line 435 of jquery.fancybox.js we have setTimeout instead of setInterval – and of course on line 429 we also have clearTimer instead of clearInterval."

[qwertykeith]

hey @ndunand , thanks for that, i had used the latest code from github assuming the change would have been made here... are you suggesting i manually edit my version of the fancybox code directly? do you think the bug will be fixed for the next version (next time fb updates i don't want to override the fix locally)?

btw/ your fix worked perfectly, thanks again!

[LucasKauz]

@ndunand Thanks for the fix! The official release have the same bug with the play() API call...