Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $.browser checks to enable support for jQuery 1.9 #485

Closed
daneah opened this Issue Jan 15, 2013 · 12 comments

Comments

Projects
None yet
7 participants
@daneah
Copy link

daneah commented Jan 15, 2013

I realize the documentation suggests linking jQuery 1.8, but for anyone linking to the latest jQuery fancyBox is now broken. jQuery 1.9 removed the $.browser functionality and fancyBox breaks when trying to check if $.browser.msie is true.

@fancyapps

This comment has been minimized.

Copy link
Owner

fancyapps commented Jan 15, 2013

Well, I really hoped to publish v3 when jQuery 1.9 comes out, but unfortunately, they made a bug (http://bugs.jquery.com/ticket/13183) that breaks the script. So, looks like that v3 will have to wait and I have to patch current version :/

@daneah

This comment has been minimized.

Copy link
Author

daneah commented Jan 15, 2013

Ah, that's too bad. Not too big a problem, as it's easy to switch the link over to jQuery 1.8 instead of jQuery-latest. Some people will be in for a surprise though! Thanks for replying, and I look forward to the update!

@yamanote1138

This comment has been minimized.

Copy link

yamanote1138 commented Jan 15, 2013

not sure if it is related, but I was seeing errors in the console like this:

can not read property 'msie' of undefined

I was able to patch, by changing all checks for this:

f.browser.msie

into this:

f.browser && f.browser.msie

not a perfect patch, for sure. but thought I might mention it if it's helpful to anyone.
this at least resolved the issues in the latest version of Chrome.

@JFKDIAZ

This comment has been minimized.

Copy link

JFKDIAZ commented Jan 15, 2013

It seems like fancybox v1.3.4 is also affected. Any one using <script src="http://code.jquery.com/jquery-latest.js"></script> to call jQuery in their current implementations will see issues with any version of fancybox.

@JFKDIAZ

This comment has been minimized.

Copy link

JFKDIAZ commented Jan 15, 2013

We'll see lots of questions soon regarding this issue in stackoverflow. I opened this question/answer in the meantime : http://stackoverflow.com/q/14344289/1055987

@fancyapps

This comment has been minimized.

Copy link
Owner

fancyapps commented Jan 16, 2013

Update to the latest

@blanchma

This comment has been minimized.

Copy link

blanchma commented Jan 2, 2014

I have the latest version of FancyApp and Jquery 1.10 and $.fancybox() returns undefined.

@baszero

This comment has been minimized.

Copy link

baszero commented Aug 21, 2015

Is there any solution for the combination Fancybox 1.3.x and jQuery 1.9+ (actually I want 1.11) ? Fancybox 2 is not free of charge anymore... So I want to stick with 1.3.x

@SalahAdDin

This comment has been minimized.

Copy link

SalahAdDin commented Aug 22, 2015

But, aren't you using the latest fancybox release version? The 3.0 version branch work for you?
Please, re open this issue.

@baszero

This comment has been minimized.

Copy link

baszero commented Aug 24, 2015

ALTERNATIVE: For all people having the same issues with 1.3.4 and jQuery 1.9+: you can switch to a very similar (and 100% equally good and free) alternative: http://dimsemenov.com/plugins/magnific-popup/

I am now using that "lightbox" and it works like a charm with jQuery 1.11 and it is also free.

@SalahAdDin

This comment has been minimized.

Copy link

SalahAdDin commented Aug 24, 2015

It's sad that this repository is "dead".

@baszero

This comment has been minimized.

Copy link

baszero commented Aug 24, 2015

It's ok to switch from opensource to a commercial version (see Fancybox 2). But as said, you can very easily switch to Magnific Popup, looks actually a lot more modern out of the box than the Fancybox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.