New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial scale behavior broken in Safari 11–13 #136
Comments
same on Edge, Chrome and Firefox !
Setting |
1+: the thumbs don't reflect landscape / portrait orientation of the images .... |
@gj52 Your example works as expected (after replacing |
Anyone here to help with this portrait picture error? |
@gj52 I do not understand your comment. I do not understand what you call an error. I don't see any problem and no one else has complained about it. |
I refer to @joshuaiz 1st entry here. and my comments 1+: the thumbs don't reflect landscape / portrait orientation of the images Plz do not mix with my crosslink! |
1+: All thumbnails have the same aspect ratio, you can change aspect ratio using 2+: What? I already explained, I do not see any issue. Also, I do not own computer with old MacOS, therefore I am not able to debug outdated Safari versions. Also, there are no proofs that this issue is not related to some custom CSS. Look, you really have to proof that your issue exists. I do not want to waste time asking tens of questions just to clarify. |
@joshuaiz has a Mac, I work with a fully patched Windows 11. Latest Edge, Firefox and Chrome! OK, all thumbs have the same aspect ratio. Accepted. --fancybox-thumbs-ratio was not defined in the loaded CSS. I added it! for the portrait images, I found a solution
Where are the CSS variables defined / documented? If THIS helps @@joshuaiz, he can close the issue. Regards |
This has been fixed in the latest release. |
Great update - thank you!
Working on a project and my client is running macOS High Sierra and was seeing some unexpected scale behavior when clicking on a Fancybox-designated image.
On click, the image is scaled to fill the viewport instead of being contained within the viewport (expected).
Here is a screenshot of the behavior:
Here is a screenshot of the expected behavior:
^^ in the expected version, the initial image size/scale is constrained to the viewport or window. In Safari versions 11–13, the image is scaled all the way to the width of the container.
This seems to be fixed in Big Sur but was able to reproduce the behavior using Browserstack with Safari + High Sierra/Mojave/Catalina.
Not sure if this is a Safari bug but initially was having a hard time counteracting it with CSS.
Hopefully this may be fixed in a future update?
The text was updated successfully, but these errors were encountered: