Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you need to multiply the result of final conv by 100? #20

Closed
AbnerCSZ opened this issue Apr 11, 2019 · 3 comments
Closed

Why do you need to multiply the result of final conv by 100? #20

AbnerCSZ opened this issue Apr 11, 2019 · 3 comments

Comments

@AbnerCSZ
Copy link

In the end of model.py


        if self.training:
            return 100 * y
        else:
            min_distance = 0.9
            return F.relu(100 * y - min_distance) + min_distance # the minimum range of Velodyne is around 3 feet ~= 0.9m

Could your tell me what is the 100 means?

@AbnerCSZ AbnerCSZ changed the title Why do you need to multiply the result of finnal conv by 100? Why do you need to multiply the result of final conv by 100? Apr 11, 2019
@fangchangma
Copy link
Owner

Could your tell me what is the 100 means?

It was legacy code and removing the multiplier should not affect the training much. However, the learning rate might require some adjustment.

@AbnerCSZ
Copy link
Author

Thank you, by the way, why not add smooth loss in the dense d mode(args.w2 = 0 when mode is d). Have you compared the difference?

@fangchangma
Copy link
Owner

Thank you, by the way, why not add smooth loss in the dense d mode(args.w2 = 0 when mode is d). Have you compared the difference?

I believe I did the experiment but did not observe improvement. Please let me know if you observe otherwise.

@AbnerCSZ AbnerCSZ closed this as completed May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants